Re: Problems with 2.0b25

From: Martin Schulze <joey_at_finlandia.Infodrom.North.DE_at_hypermail-project.org>
Date: Wed, 27 Oct 1999 01:07:07 +0200
Message-ID: <19991027010707.A12727_at_finlandia.infodrom.north.de>

Martin Schulze wrote:
> Hi,
>
> I'm having problems working with 2.0b25:
>
> a) hypermail -m received -x -c spam.config -p
>
> I get:
>
> hypermail: Couldn't create lock file "received/.hypermail.lock".
>
> Shouldn't this read the configuration from spam.config and process
> `received' like a mailbox in mbox format?
>
> b) cat received hypermail -c spam.config -p
>
> This processes received, but
>
> . ignores everything written in spam.config and

Ok, this problem has been detected.

Somebody decided to change the format of the config file.

Folks, this is not how sofware ought to be developed. Patch is:

Index: src/setup.c

---

RCS file: /home/archive/debian/hypermail/src/setup.c,v retrieving revision 1.1.1.1

diff -u -r1.1.1.1 setup.c
--- src/setup.c	1999/10/26 20:30:59	1.1.1.1
+++ src/setup.c	1999/10/26 21:58:09

_at_@ -415,12 +415,16 @@

   return; /* nothing currently */
 }  

-int ConfigAddItem(char *line)
+int ConfigAddItem(char *cfg_line)
 {
   char keyword[256];
   char towhat[501];
   char *keywp;
   int i;

+  char *line = cfg_line;
+
+  if (!strncmp (line, "set ", 4))
+    line+=4;
 
   if (2 <= sscanf(line, " %255[a-zA-Z0-9._] %*[=: ] %500[^\n]",
                   keyword, towhat)) {

c) Not working is:

        hm_showheaders = 1

The result (rendered through lynx) looks like:

   Return-Path: <joey_at_master.debian.org> Received: at Infodrom Oldenburg (/\##/\ Smail-3.2.0.102 1998-Aug-2 #2) from    master.debian.org by finlandia.Infodrom.North.DE via smail with smtp id <m11WGRU-000bA4C_at_finlandia.Infodrom.North.DE> for    <joey_at_infodrom.north.de>; Wed, 29 Sep 1999 11:54:32 +0200 (CEST) Received: from ([209.41.108.5]) by teergrube (0 sec    delayed, relaying denied) Received: (qmail 8012 invoked by uid 847); 29 Sep 1999 09:54:07 -0000 Received: (qmail 8006    invoked from network); 29 Sep 1999 09:54:06 -0000 Received: from smtp.www-service.de (root_at_212.77.161.16) by    master.debian.org with SMTP; 29 Sep 1999 09:54:06 -0000 Received: from KOMM-Server.bhv-lk.net ([194.172.45.162]) by    smtp.www-service.de (8.9.3/8.9.3) with ESMTP id LAA02623 for <joey_at_debian.org>; Wed, 29 Sep 1999 11:53:07 +0200 (CEST)

Probably somebody forgot to add <pre> and </pre> somewhere. Patch follows:

Index: src/print.c

---

RCS file: /home/archive/debian/hypermail/src/print.c,v retrieving revision 1.3
diff -u -r1.3 print.c

--- src/print.c	1999/10/26 21:56:34	1.3
+++ src/print.c	1999/10/26 22:41:16
_at_@ -509,6 +509,15 @@
             bp = bp->next;
             continue;
         }
+
+	if (bp->header && !pre) {
+	    fprintf(fp, "<PRE>\n");
+	    pre = 1;
+	}
+	if (!bp->header && pre &&set_showheaders) {
+	    fprintf(fp, "</PRE>\n");
+	    pre = 1;
+	}
 
         if ((bp->line)[0] == '\n' && inblank) {
             bp = bp->next;

Additionally, according to the documentation only selected header lines should be displayed (set by hm_show__headers = foo bar baz) *and* hm_showheaders. This functionality got lost. Patch will follow (probably 2morrow).

       hm_show_headers = list_of_RFC_Headers_to_display
              This is the list of  headers  to  be  displayed  if
              hm_showheaders  is  set  to  1  (TRUE). They can be
              listed comma or space separated  all  on  a  single
              line.   If  it contains the special character ``*''
              hypermail will display all header lines.

       hm_showheaders = boolean_number
              Set this to 1
               to  show  the article header lines in the archived
              HTML files. These lines typically include the To: ,
              From:  ,  and  Subject:  information  found in most
              email messages.

Regards,

        Joey

-- 
The only stupid question is the unasked one.

Please always Cc to me when replying to me on the lists.

Received on Wed 27 Oct 1999 01:08:24 AM GMT